UX: Keep selection synced with note visibility #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot the case where someone creates a new note and fixed it in this PR. This closes #1507. |
|
Hey @kazup01, got any update on the review process? This PR is really nice to have. I notice when I switch laptops (one with this PR applied and one with vanilla Boostnote). |
|
Hi @Redsandro , yeah this PR is awesome. We have many tasks now, so wait a while please. |
|
Merged. Thank you for your contribution and waiting @Redsandro :) |
kazup01
added
next release (v0.9.1)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two UX bugs:
Previously, it was confusing to follow what's going on, because the selection and note visibility were not synced. This demonstrates the old behavior. Play close attention to the note in view on the right, and the selection in the note list:
With this PR, the selected note will remain selected as long as it's part of the subset (e.g. when searching or changing storage), and if not, when the first note is automatically viewed (old behavior) the selection will be updated to match: