Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color update #1268

Merged
merged 9 commits into from
Dec 12, 2017
Merged

Color update #1268

merged 9 commits into from
Dec 12, 2017

Conversation

ytk141
Copy link
Contributor

@ytk141 ytk141 commented Dec 11, 2017

  • Update Dark Theme Color
  • Hidden zoom panel
  • Change Note Detail Icon Color

ver a

@BoostnoteBot
Copy link
Collaborator

Please make sure to be pasted screenshots of all your changes.

@BoostnoteBot
Copy link
Collaborator

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@kazup01
Copy link
Member

kazup01 commented Dec 11, 2017

Hi @ytk141 , thanks for contribution! Please check the below.

  • The Star button in SideNavFilter is expanding when active, so please improve it.
    dec-11-0029 17-23-01

  • There is a weird margin when the Progress bar is active, so please fix it.

screen shot 0029-12-11 at 5 37 51 pm

@kazup01 kazup01 self-requested a review December 11, 2017 08:38
@kazup01 kazup01 added the awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. label Dec 11, 2017
This was referenced Dec 11, 2017
Closed
Closed
@ytk141
Copy link
Contributor Author

ytk141 commented Dec 11, 2017

@kazup01 Fixed bugs adove!

@kazup01
Copy link
Member

kazup01 commented Dec 11, 2017

Cool!

@ytk141
Copy link
Contributor Author

ytk141 commented Dec 12, 2017

@kazup01 Updated some styles. plz check it :)

kazup01
kazup01 approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 57f4aa5 into BoostIO:master Dec 12, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 12, 2017

Merged! Thanks @ytk141 <3

@kazup01
Copy link
Member

kazup01 commented Dec 12, 2017

I will fix CI error soon.

@kazup01 kazup01 added next release (v0.8.19) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. Next Release labels Dec 12, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
@ghost ghost mentioned this pull request Dec 26, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazup01 kazup01 kazup01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytk141 @BoostnoteBot @kazup01