Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple addon for CodeMirror #1126

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Conversation

yamash723
Copy link
Contributor

Hi. Thanks for Boostnote. It's very useful.
but, Boostnote can't syntax highlight Rust. CodeMirror need simple addon for the Rust.

Before

simple_addpm_before

After

simple_addon_after

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Nov 15, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 15, 2017

Thank you @yamash723 ! We will check it.

@kazup01 kazup01 merged commit 06013b2 into BoostIO:master Nov 16, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 16, 2017

Merged. Thanks @yamash723 !

@kazup01 kazup01 added next release (v0.8.17) and removed awaiting review ❇️ Pull request is awaiting a review. Next Release labels Nov 16, 2017
@yamash723 yamash723 deleted the add-simple-addon branch November 17, 2017 01:05
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants