Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported image source path is incorrect #2815

Closed
alelom opened this issue Jan 17, 2019 · 9 comments
Closed

Exported image source path is incorrect #2815

alelom opened this issue Jan 17, 2019 · 9 comments
Labels
bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work.

Comments

@alelom
Copy link

alelom commented Jan 17, 2019

Current behavior

Images source path incorrectly placed by Boostnote. It inserts the '%5C' instead of the character '/'.
Therefore source path looks like:
src="attachments%5C9fad04b1.PNG"
when it should be:
src="attachments/fad04b1.PNG"

Result is that the HTML has broken images links:
untitled

Replacing the wrong characters in the HTML file solves the problem.

Steps to reproduce

  1. Insert any image with Drag&Drop
  2. Export in HTML

Environment

  • Version : 0.11.12
  • OS Version and name : Windows 7
@MiloTodt
Copy link
Contributor

Can confirm that this error is present on Windows 10 with the official Boostnote release.

It is not present when on the masterbranch of 0.11.13. I think this issue has been addressed and fixed in the new version.

@ZeroX-DG ZeroX-DG added the bug 🐛 Issue concerns a bug. label Jan 19, 2019
@ehhc
Copy link
Contributor

ehhc commented Feb 24, 2019

In the current version the issue is present again. I think that's also what is mentioned here: #2834 (comment)

ehhc added a commit to ehhc/Boostnote that referenced this issue Feb 24, 2019
@incredibleweirdo
Copy link

incredibleweirdo commented May 30, 2019

Hello,
I want to report that I am experiencing this issue as well, though I'm not 100% certain it is the same.
When I export HTML, the image source path has an additional directory specified that does not exist/is not created in the attachments folder.
When exporting HTML, any images in the markdown are exported directly in the attachments folder that is created:
image
However, the path in the HTML files contains an additional directory below attachments which does not exist:
image

This is on 0.11.13. I can't validate the behavior on 0.11.16 nor 0.11.17 because another issue #2968 is preventing me from exporting HTML at all.

@incredibleweirdo
Copy link

More to add!
In dealing with both #2968 and #3018 I found that if I make an edit to "fix" those issues, I can see that the image source path is still bad in 0.11.16 and in 0.11.17. There is still an extra directory in the attachments folder which does not exists, specified in the path.
However, there is also another issue with the generated path, in 0.11.16 and 0.11.17 - the image source path in the HTML (and maybe PDF? the PDF images are also broken) no longer references the attachments folder - it references :storage at the start of the path:
image

@ehhc
Copy link
Contributor

ehhc commented May 31, 2019

@incredibleweirdo can you have a look, if this pr fixes your problem? #2897

@incredibleweirdo
Copy link

@ehhc I cannot test that PR, sadly. I get an error when running yarn on that PR's branch.

$ yarn
yarn install v1.16.0
[1/4] Resolving packages...
[2/4] Fetching packages...
error An unexpected error occurred: "https://registry.yarnpkg.com/js-sequence-diagrams/-/js-sequence-diagrams-1000000.0.6.tgz: Request failed \"404 Not Found\"".
info If you think this is a bug, please open a bug report with the information provided in "D:\\projects
\\Boostnote\\yarn-error.log".

@ehhc
Copy link
Contributor

ehhc commented May 31, 2019

@incredibleweirdo i'm sorry to hear that... i fear i don't have the time to look into the bug :(
maybe one of the maintainer @Rokt33r @ZeroX-DG has time and an idea how to fix it? Maybe they even can have a look at the various PRs? :)

@incredibleweirdo
Copy link

@ehhc I was able to finally test, see my comment here -#2897 (comment)

@Flexo013 Flexo013 added the level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work. label Oct 30, 2019
@Flexo013
Copy link
Contributor

Duplicate of #2785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work.
Projects
None yet
Development

No branches or pull requests

6 participants