Refactor component system #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… individual files add comments for relfection code add new components instance add postLoad for resource Fix wall object update object asset postLoad resource for component rename new_components to be components remove redunt logic in object refactor level asset: using instanced component for transform fix transform and rigidbody post loaded remove useless files
…1/PilotV into refactor-component-system
Ol6rin
reviewed
May 16, 2022
| "asset/objects/character/player/components/animation/data/anim.skeleton_map.json" | ||
| ], | ||
| "blend_clip_file_length": [ | ||
| 0.76666998863220215 |
There was a problem hiding this comment.
Seems like saved from editor? the value changed due to rounding methods
| "controller_config": { | ||
| "$context": { | ||
| "capsule_shape": { | ||
| "half_height": 0.69999998807907104, |
There was a problem hiding this comment.
Same rounding problem here
| } | ||
| } | ||
| }, | ||
| "$typeName": "TransformComponent" |
There was a problem hiding this comment.
What's the purpose of TransformComponent in object definition
Closed
KaygNas
pushed a commit
to KaygNas/Piccolo
that referenced
this pull request
Feb 10, 2023
- store components data in objects instead of individual files - remove useless component files - move component editor tick property into `g_editor_tick_component_types` - load components from instanced data firstly, then load from the definition - transform as the normal instanced component - add `postLoadResource` interface for component loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_editor_tick_component_typespostLoadResourceinterface for component loading