Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide language preference for guest account #5356

Closed
BuchoMarales opened this issue Dec 11, 2024 · 3 comments
Closed

Hide language preference for guest account #5356

BuchoMarales opened this issue Dec 11, 2024 · 3 comments

Comments

@BuchoMarales
Copy link

BuchoMarales commented Dec 11, 2024

Describe the Bug

Hi Guys,

First of all, muchas gracias, for what you have created so far :) Been enjoying BookStack

One issue I have stumbled upon though is it allowing me to select a language different to English under the default Guest user settings and even saving the settings, yet if I try loading the frontpage or go back to the user settings everything will still be in English with language settings defaulted back to English.

Works flawlessly for a standard user though

Thanks for your help and efforts

Steps to Reproduce

  1. Go to Settings >> Users >> Guest
  2. Set Preferred Language to anything but English
  3. Save settings
  4. Go to the landing page as a Guest user.
  5. Confirm everything is in English
  6. Go to Settings >> Users >> Guest
  7. Confirm Preferred Language is set to English

Expected Behaviour

Expect it to save language settings for a Guest user

Screenshots or Additional Context

No response

Browser Details

Chrome Version 131.0.6778.109 (Official Build) (64-bit)

Exact BookStack Version

BookStack v24.10.3

@ssddanbrown
Copy link
Member

Hi @BuchoMarales,
The default language (and that used for guest users) can be configured as detailed in our docs here:
https://www.bookstackapp.com/docs/admin/language-config/

By default, the autodetection of the language based upon browser preferences will used, which is configured via a APP_AUTO_LANG_PUBLIC as detailed on that page.

Maybe we should hide the language preference option though for the guest user to prevent future confusion, since it is effectively redundant.

@ssddanbrown ssddanbrown added this to the v24.12 milestone Dec 12, 2024
@BuchoMarales
Copy link
Author

BuchoMarales commented Dec 13, 2024

Hi @ssddanbrown,

Thanks for checking ! Now everything is all good :)

Thanks a lot

@ssddanbrown ssddanbrown changed the title Language settings are not getting saved for a default Guest user Hide language preference for guest account Dec 13, 2024
ssddanbrown added a commit that referenced this issue Dec 13, 2024
Hiding since it's not really used, and may mislead on how to set default
app language (which should be done via env options).
Updated test to cover.

For #5356
@ssddanbrown
Copy link
Member

@BuchoMarales Good to hear!

I've recategorised this issue to focus on, and made changes in a8ef820, to hide the language preference for the guest user to help avoid any similar confusion in future.
This will be part of the next feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants