feat: add spinnaker_pipeline_template_v2 resource #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinohmann
force-pushed
the
pipeline-template-v2
branch
7 times, most recently
from
976a924
to
3143cf2
Compare
martinohmann
requested review from
mmartins-bonial,
pesarkhobeee,
pjungermann,
rodin-bonial and
sydorovdmytro
Notable changes: - add `ResponseError` to make working with API errors easier - add validation to the `template` field of the new `spinnaker_pipeline_template_v2` resource to catch common issues on `terraform plan` - tests for error impl and parsing/validation logic More tests require general changes to the way the API client is instantiated and passed around. This is out of scope here and will be addressed in a separate change.
martinohmann
force-pushed
the
pipeline-template-v2
branch
from
3143cf2
to
dd6cd2d
Compare
pjungermann
reviewed
May 28, 2021
pjungermann
reviewed
May 28, 2021
pjungermann
approved these changes
May 28, 2021
pjungermann
approved these changes
May 28, 2021
martinohmann
added a commit
that referenced
this pull request
Jul 6, 2021
This adjusts the pipelines API to make use of the `ResponseError` implementation added in #13. Furthermore it fixes a bug where non-existent pipelines produce errors although terraform should just recreate them.
martinohmann
added a commit
that referenced
this pull request
Jul 6, 2021
This adjusts the pipelines API to make use of the `ResponseError` implementation added in #13. Furthermore it fixes a bug where non-existent pipelines produce errors although terraform should just recreate them.
martinohmann
added a commit
that referenced
this pull request
Jul 6, 2021
This adjusts the pipelines API to make use of the `ResponseError` implementation added in #13. Furthermore it fixes a bug where non-existent pipelines produce errors although terraform should just recreate them.
martinohmann
added a commit
that referenced
this pull request
Jul 6, 2021
This adjusts the pipelines API to make use of the `ResponseError` implementation added in #13. Furthermore it fixes a bug where non-existent pipelines produce errors although terraform should just recreate them.
martinohmann
added a commit
that referenced
this pull request
Jul 6, 2021
This adjusts the pipelines API to make use of the `ResponseError` implementation added in #13. Furthermore it fixes a bug where non-existent pipelines produce errors although terraform should just recreate them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
ResponseErrorto make working with API errors easiertemplatefield of the newspinnaker_pipeline_template_v2resource to catch common issues onterraform planMore tests require general changes to the way the API client is
instantiated and passed around. This is out of scope here and will be
addressed in a separate change.
Note that other API calls now could also benefit from
ResponseErrorto simplify the code but changing this is out of scope of this change as well.