fix: lazily initialize gate API client #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinohmann
requested review from
mmartins-bonial,
nilsmull,
pesarkhobeee,
rodin-bonial and
sydorovdmytro
The initialization of the gate API client results in an immediate API
call to the `/version` endpoint. This makes it impossible to use the
provider inside of a module that will create the spinnaker as well
because the presence of the `provider "spinnaker" {}` block alone will
result in an API call to a non-existent endpoint.
This change delays the initialization of the gate API client until it is
needed. That allows the creation of the spinnaker and resources managed
by the spinnaker provider inside the same module by leveraging
`depends_on`.
The change also adds a `Makefile` to build and install the provider for
local testing as this has become a pain starting with terraform 0.13.
martinohmann
force-pushed
the
lazy-gate-client
branch
from
387f7b1
to
4a66410
Compare
sydorovdmytro
approved these changes
May 18, 2021
pesarkhobeee
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initialization of the gate API client results in an immediate API
call to the
/versionendpoint. This makes it impossible to use theprovider inside a module that will create the spinnaker as well
because the presence of the
provider "spinnaker" {}block alone willresult in an API call to a non-existent endpoint.
This change delays the initialization of the gate API client until it is
needed. That allows the creation of the spinnaker and resources managed
by the spinnaker provider inside the same module by leveraging
depends_on.The change also adds a
Makefileto build and install the provider forlocal testing as this has become a pain starting with terraform 0.13.