getStringAsync should return BFTask #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't this be returning BFTask rather than NSString since it's async?
|
Sorry for the hassle, but would you mind accepting the Facebook contributor license agreement so that we can merge this in and give you proper attribution? Thanks! |
|
No worries, just done it 😄 |
bklimt
added a commit
that referenced
this pull request
Jan 30, 2014
getStringAsync should return BFTask
depoll
pushed a commit
that referenced
this pull request
Apr 30, 2014
Initial version of iOS AppLinks.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't this be returning BFTask rather than NSString since it's async?