Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M2P-587] Flips in_array args to be correct #1276

Merged
merged 3 commits into from
May 6, 2021

Conversation

njfaries
Copy link
Contributor

@njfaries njfaries commented May 6, 2021

Description

Flips in_array args.

Test case added for unit tests. Fails when I flipped the arguments back around.

Fixes: https://boltpay.atlassian.net/browse/M2P-587

#changelog WIP [M2P-587] Flips in_array args to be correct

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please validate that you have tested your change in at least one of the following areas:

  • Successfully tested locally (or docker image)
  • Successfully tested on a staging or sandbox server
  • Successfully tested on a merchant's staging server

For PR Reviewer

  • Reviewed unit tests to make sure we are using real components rather than mocks as much as possible?
  • For any major change (observer, new Bolt feature, core Magento interaction) we must add a feature switch, did you verify this?

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • New and existing unit tests pass locally with my changes.
  • I have created or modified unit tests to sufficiently cover my changes.
  • I have added my Jira ticket link and provided a changelog message.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #1276 (50dedea) into master (ac4aff3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1276   +/-   ##
=========================================
  Coverage     71.81%   71.82%           
  Complexity     3060     3060           
=========================================
  Files           192      192           
  Lines         10429    10429           
=========================================
+ Hits           7490     7491    +1     
+ Misses         2939     2938    -1     

@njfaries njfaries changed the title WIP [M2P-587] Flips in_array args to be correct [M2P-587] Flips in_array args to be correct May 6, 2021
@njfaries njfaries merged commit aedc0cf into master May 6, 2021
@njfaries njfaries deleted the nathaniel/flip_in_array_args branch May 6, 2021 19:55
danac-gs pushed a commit that referenced this pull request Jun 1, 2021
* Flips in_array args to be correct

* Fixed typo in CustomFieldsHandler, added new test case

* whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants