Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2P-584 Use integration test instead of unit test for all methods in class Bolt\Boltpay\Test\Unit\Plugin\SalesRuleQuoteDiscountPluginTest #1269

Merged
merged 1 commit into from
May 7, 2021

Conversation

johnmccombs1
Copy link
Contributor

@johnmccombs1 johnmccombs1 commented May 3, 2021

Description

Use integration test instead of unit test for all methods in class Bolt\Boltpay\Test\Unit\Plugin\SalesRuleQuoteDiscountPluginTest

Fixes: https://boltpay.atlassian.net/browse/M2P-584

#changelog M2P-584 Use integration test instead of unit test for all methods in class Bolt\Boltpay\Test\Unit\Plugin\SalesRuleQuoteDiscountPluginTest

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please validate that you have tested your change in at least one of the following areas:

  • Successfully tested locally (or docker image)
  • Successfully tested on a staging or sandbox server
  • Successfully tested on a merchant's staging server

For PR Reviewer

  • Reviewed unit tests to make sure we are using real components rather than mocks as much as possible?
  • For any major change (observer, new Bolt feature, core Magento interaction) we must add a feature switch, did you verify this?

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • New and existing unit tests pass locally with my changes.
  • I have created or modified unit tests to sufficiently cover my changes.
  • I have added my Jira ticket link and provided a changelog message.

…lt\Boltpay\Test\Unit\Plugin\SalesRuleQuoteDiscountPluginTest
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #1269 (531827f) into master (ca58756) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1269   +/-   ##
=========================================
  Coverage     70.93%   70.93%           
  Complexity     3084     3084           
=========================================
  Files           194      194           
  Lines         10527    10527           
=========================================
  Hits           7467     7467           
  Misses         3060     3060           

@johnmccombs1 johnmccombs1 merged commit 35a980d into master May 7, 2021
@johnmccombs1 johnmccombs1 deleted the integration_test/salesrulequotediscountplugin branch May 7, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants