Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN-4581 Bugfix: back office needs to be refreshed for button to show #1266

Merged
merged 4 commits into from
May 10, 2021

Conversation

dumega
Copy link
Contributor

@dumega dumega commented Apr 30, 2021

Description

Root cause: if the merchant site enables multi stores and the default store does not have Bolt enabled, the related JS and Bolt keys are not loaded on the backoffice order creation page.

Solution:

  1. We always load replacejs.phtml for the backoffice order creation.
  2. Loads Bolt keys and connect url by current store id instead of default store id.
  3. Builds api request content by current store id.

Fixes: https://boltpay.atlassian.net/browse/EN-4581

#changelog Bugfix: back office needs to be refreshed for button to show

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please validate that you have tested your change in at least one of the following areas:

  • Successfully tested locally (or docker image)
  • Successfully tested on a staging or sandbox server
  • Successfully tested on a merchant's staging server

For PR Reviewer

  • Reviewed unit tests to make sure we are using real components rather than mocks as much as possible?
  • For any major change (observer, new Bolt feature, core Magento interaction) we must add a feature switch, did you verify this?

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • New and existing unit tests pass locally with my changes.
  • I have created or modified unit tests to sufficiently cover my changes.
  • I have added my Jira ticket link and provided a changelog message.

@dumega dumega marked this pull request as draft April 30, 2021 09:59
@dumega dumega marked this pull request as ready for review April 30, 2021 12:02
@njfaries njfaries merged commit 233c363 into master May 10, 2021
@njfaries njfaries deleted the ning-fix-backoffice-not-load branch May 10, 2021 15:28
danac-gs pushed a commit that referenced this pull request Jun 1, 2021
…1266)

* Bugfix: back office needs to be refreshed for button to show

* fix tests

* fix tests

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants