Don't reload on watchdog 'opened' events #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of watchdog >= 2.3, file open events on certain platforms are causing an 'opened' event to be delivered. We should not be restarting the server on these changes, as they can be spammy and disruptive. I was able to confirm the behaviour by running the tests within a debian-like environment (python slim bullseye); without the fix, the `tests/test_watch.py` would fail for the first test case (the evented observer)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of watchdog >= 2.3, file open events on certain platforms are causing an 'opened' event to be delivered. We should not be restarting the server on these changes, as they can be spammy and disruptive.
I was able to confirm the behaviour by running the tests within a debian-like environment (python slim bullseye); without the fix, the
tests/test_watch.pywould fail for the first test case (the evented observer)For more context, see discussions here: