Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More initiator fixes #122

Merged
merged 10 commits into from
Feb 12, 2024
Merged

More initiator fixes #122

merged 10 commits into from
Feb 12, 2024

Conversation

erichelgeson
Copy link
Contributor

Going though a box of SCSI drives I found. Fixes so far:

  • Correctly ID SCSI-1 drives
  • Don't reset bus - causes some drives to hang, no issues if skipped.
  • Fix logging of retry count
  • Fix image file opening as readable when never read from
  • Report how many unrecoverable bad sectors were found.
  • Print % complete in log.
  • InitatorMaxRetry - default 5 - min 0 -> max 255
  • Eject and continue scanning IDs that have CD's or Eject-able media.
  • Fix incorrect sense key parsing.

Copy link
Contributor

@androda androda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to test these changes yet, but they make sense.

@erichelgeson erichelgeson merged commit 929903d into main Feb 12, 2024
1 check passed
@erichelgeson erichelgeson deleted the eric/moreInitiatorFixes branch February 12, 2024 21:54
morio added a commit to ZuluSCSI/ZuluSCSI-firmware that referenced this pull request Feb 16, 2024
Changes adapted from @erichelgeson pull request:
BlueSCSI/BlueSCSI-v2#122

Changes from the above pull request
 - Correctly ID SCSI-1 drives
 - Don't reset bus - causes some drives to hang, no issues if skipped.
 - Fix logging of retry count
 - Fix image file opening as readable when never read from
 - Report how many unrecoverable bad sectors were found.
 - Print % complete in log.
 - InitiatorMaxRetry - default 5 - min 0 -> max 255
 - Eject and continue scanning IDs that have CD's or Eject-able media.
 - Fix incorrect sense key parsing.

Local Changes
 - Support for device with the removable flag
 - Support for Magneto-optical drives - writes as `MOx0_imaged(x).img`
 - Support for removable devices like zip drives and other devices.
   Writes as `RMx0_imaged(x).img`
 - Every time a removable media is inserted it the image filename
   increments the number between the "(x)" parenthesis e.g.
   `CD30_imaged(3).iso`
 - The ability to copy and paste `zuluscsi.ini` text from the log,
   including Vendor, Product, Version, and Type along with the SCSI
   device header `[SCSIx]`
morio added a commit to ZuluSCSI/ZuluSCSI-firmware that referenced this pull request Feb 16, 2024
Changes adapted from @erichelgeson pull request:
BlueSCSI/BlueSCSI-v2#122

Changes from the above pull request
 - Correctly ID SCSI-1 drives
 - Don't reset bus - causes some drives to hang, no issues if skipped.
 - Fix logging of retry count
 - Fix image file opening as readable when never read from
 - Report how many unrecoverable bad sectors were found.
 - Print % complete in log.
 - InitiatorMaxRetry - default 5 - min 0 -> max 255
 - Eject and continue scanning IDs that have CD's or Eject-able media.
 - Fix incorrect sense key parsing.

Local Changes
 - Support for device with the removable flag
 - Support for Magneto-optical drives - writes as `MOx0_imaged(x).img`
 - Support for removable devices like zip drives and other devices.
   Writes as `RMx0_imaged(x).img`
 - Every time a removable media is inserted it the image filename
   increments the number between the "(x)" parenthesis e.g.
   `CD30_imaged(3).iso`
 - The ability to copy and paste `zuluscsi.ini` text from the log,
   including Vendor, Product, Version, and Type along with the SCSI
   device header `[SCSIx]`

Co-authored-by: Eric Helgeson <erichelgeson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants