Fix Apple vendor mode page sending (#272)

Apparently there was a mistake between || and && that caused Apple vendor page to be sent even when Apple quirks were disabled and when it wouldn't fit the buffer.
BlueSCSI · Sep 12, 2023 · 0abf488 · 0abf488
1 parent f27fc20
commit 0abf488
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/SCSI2SD/src/firmware/mode.c b/lib/SCSI2SD/src/firmware/mode.c
@@ -516,10 +516,8 @@ static void doModeSense(
 
 	idx += modeSenseCDCapabilitiesPage(pc, idx, pageCode, &pageFound);
 
-	if ((
-			(scsiDev.target->cfg->quirks == S2S_CFG_QUIRKS_APPLE) ||
-			(idx + sizeof(AppleVendorPage) <= allocLength)
-		) &&
+	if ((scsiDev.target->cfg->quirks == S2S_CFG_QUIRKS_APPLE) &&
+	    (idx + sizeof(AppleVendorPage) <= allocLength) &&
 		(pageCode == 0x30 || pageCode == 0x3F))
 	{
 		pageFound = 1;