-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice Recorder iOS 17 style #2697
Conversation
update voice message recorder with iOS 17 style
FYI, we still plan to review this, just haven't had a chance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make a few changes to the implementation just to cut down on the modifications, but they're hard to describe so once you finish these minor things I'll merge it and update from there. Thanks for the contribution!
lib/app/layouts/conversation_view/colors/voice_message_recorder_colors.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/text_field_suffix.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/text_field_suffix.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/text_field_suffix.dart
Outdated
Show resolved
Hide resolved
lib/app/layouts/conversation_view/widgets/text_field/conversation_text_field.dart
Outdated
Show resolved
Hide resolved
Thanks for the review 😁 I've updated the PR with suggested changes. With custom colours is that something you don't want in general, or could this be behind a flag somewhere in the theme settings for example. Also for the original waveform colour it's currently set to white, might just be me, but it's hard to see in light mode when recording, maybe that could also be changed in this PR? 🤔 Here's a screenshot of what I mean |
I'll try and get around to reviewing it here soon, but in the meantime:
We might expose this via theme settings but for now I think its best that it follows the more global theme settings for best integration with Material You and all that
I agree, I would set this to the background color of the "stop" icon in your image. |
@zlshames this would be nice to merge as an iOS UI update |
thank you for the contribution! |
Updating the style for the voice recoder widget for the iOS skin. In iOS 17 there is a new waveform icon that's not avaliable in flutter, so have to add a custom icon here as a font.
This is what it looks like on iOS 17, while voice recorder is recording
Updated version on BB app in dark and light themes.
Work done:
VoiceMessageRecorder
conversation_text_field
with new widget, and using themed colors for the text field when audio is being recordedtext_field_suffix
to use the new waveform icon and themed colors for iOS variantTested on Google Pixel 6 with all 3 skins avaliable in the app