Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower: Update synthesis suite #2102

Merged
merged 15 commits into from
Sep 6, 2023

Conversation

adrien-berchet
Copy link
Member

@adrien-berchet adrien-berchet commented Aug 26, 2023

No description provided.

@github-actions
Copy link

There are one or more issues with the title of this PR.
There are one or more issues with the commit message of commit dcbf381.
Commit message:

Update synthesis suite

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

  • The following packages were changed but not mentioned:
    py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@bbpbuildbot
Copy link
Collaborator

Thank you for your pull request!

Should you want to clear the PR build directory after failures, please use this pipeline. Before running the cleanup pipeline, please ensure that any PR building pipelines have been cancelled or finished running.

@adrien-berchet adrien-berchet changed the title Update synthesis suite py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower: Update synthesis suite Aug 26, 2023
@github-actions
Copy link

There are one or more issues with the title of this PR.
There are one or more issues with the commit message of commit dcbf381.
Commit message:

Update synthesis suite

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

  • The following packages were changed but not mentioned:
    py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@github-actions
Copy link

There are one or more issues with the commit message of commit dcbf381.
Commit message:

Update synthesis suite

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

1 similar comment
@github-actions
Copy link

There are one or more issues with the commit message of commit dcbf381.
Commit message:

Update synthesis suite

Please satisfy at least one of the checks (one package, docs, or deploy).
The PR title must be compliant. The commit message of your commit must be compliant as well.
Issues:

  • The following packages were changed but not mentioned:
    py-diameter-synthesis, py-morph-tool, py-neurots, py-region-grower:
    You can simply use the above list, then explain what you changed.
    Alternatively, you can use one line per package to describe the change per package.
    Please mention at least one package.

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2102/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • placement-algorithm/2.3.1
  • psp-validation/0.5.0
  • py-archngv/3.0.2
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.32.dev2
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepysnap/1.0.7
  • py-brayns-circuit-studio-backend/1.0.1
  • py-connectome-manipulator/0.0.4
  • py-connectome-manipulator/0.0.6
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-neuror/1.6.4
  • py-region-grower/0.3.1

@adrien-berchet
Copy link
Member Author

@eleftherioszisis can you test your workflow with this or the PR must be merged before?

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2102/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • placement-algorithm/2.3.1
  • psp-validation/0.5.0
  • py-archngv/3.0.2
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.32.dev2
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepysnap/1.0.7
  • py-brayns-circuit-studio-backend/1.0.1
  • py-connectome-manipulator/0.0.4
  • py-connectome-manipulator/0.0.6
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-neuror/1.6.4
  • py-region-grower/0.3.1

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2102/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • placement-algorithm/2.3.1
  • psp-validation/0.5.0
  • py-archngv/3.0.2
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.32.dev2
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepysnap/1.0.7
  • py-brayns-circuit-studio-backend/1.0.1
  • py-connectome-manipulator/0.0.4
  • py-connectome-manipulator/0.0.6
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-neuror/1.6.4
  • py-region-grower/0.3.1

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

Please fix the following packages that failed to build:

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2102/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • placement-algorithm/2.3.1
  • psp-validation/0.5.0
  • py-archngv/3.0.2
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.32.dev3
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepysnap/1.0.7
  • py-brayns-circuit-studio-backend/1.0.1
  • py-connectome-manipulator/0.0.4
  • py-connectome-manipulator/0.0.7
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-neuror/1.6.4
  • py-region-grower/0.4.3

matz-e
matz-e previously approved these changes Sep 1, 2023
@matz-e
Copy link
Member

matz-e commented Sep 4, 2023

#2108 contains the update of Pandas.

Thanks! Is there anything I should do? Or you will merge #2108 and then we'll just have to rebase this one?

If we go with Pandas 2, I'll merge that one and then this one will have to be rebased.

@adrien-berchet
Copy link
Member Author

Ok, I'll wait you to merge the other one and then rebase this one. Thanks!

@adrien-berchet
Copy link
Member Author

Ah and I have another question: should I remove the versions that are not explicitly used by another package and that are already contained in a previous archive?

@matz-e
Copy link
Member

matz-e commented Sep 4, 2023

Ah and I have another question: should I remove the versions that are not explicitly used by another package and that are already contained in a previous archive?

You can do that if it simplifies the package significantly.

@bbpbuildbot
Copy link
Collaborator

The following build jobs of the deployment for this PR failed:

@eleftherioszisis
Copy link

@adrien-berchet , @arnaudon , is the pandas>=2.0 required, or could we relax it?

@adrien-berchet
Copy link
Member Author

@adrien-berchet , @arnaudon , is the pandas>=2.0 required, or could we relax it?

I think we can relax it, I'm working on it.

@bbpbuildbot
Copy link
Collaborator

To test your PR, use the following on BlueBrain5:

unset MODULEPATH
. /gpfs/bbp.cscs.ch/ssd/apps/bsd/pulls/2102/config/modules.sh
module load unstable

Please test the following updated modules:

  • brainbuilder/0.18.5
  • connectome-tools/0.6.2
  • placement-algorithm/2.3.1
  • psp-validation/0.5.0
  • py-amici/0.11.28
  • py-archngv/3.0.2
  • py-atlannot/0.1.3
  • py-atlas-building-tools/0.1.10
  • py-atldld/0.3.4
  • py-atlinter/0.2.4
  • py-bba-data-push/1.0.8
  • py-bba-webexporter/0.1.5
  • py-bbp-analysis-framework/1.6.42
  • py-bbp-workflow/3.1.32.dev3
  • py-bglibpy/4.10.1
  • py-bluepy/2.5.1
  • py-bluepyemodel/0.0.11
  • py-bluepymm/0.7.65
  • py-bluepyopt/1.13.86
  • py-bluepyparallel/0.0.5
  • py-bluepysnap/1.0.7
  • py-brayns-circuit-studio-backend/1.0.1
  • py-connectome-manipulator/0.0.4
  • py-connectome-manipulator/0.0.7
  • py-cwl-registry/0.3.14
  • py-dask-mpi/2022.4.0
  • py-minis-validation/0.0.5
  • py-morph-tool/2.9.1
  • py-neuror/1.6.4
  • py-nexusforge/0.8.1
  • py-region-grower/1.1.1
  • py-visual-cortex-analysis/0.0.1.dev0
  • python-dev/0.5
  • spykfunc/0.18.1

Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for relaxing the Pandas requirement! I think there's quite some work to be done for the next deployment to be able to use Pandas 2 consistently throughout our stack.

@adrien-berchet
Copy link
Member Author

Thank you for relaxing the Pandas requirement! I think there's quite some work to be done for the next deployment to be able to use Pandas 2 consistently throughout our stack.

No problem, it was simpler for everybody :)
And thank you very much for your help on this!!!

@adrien-berchet adrien-berchet merged commit 0468550 into develop Sep 6, 2023
10 checks passed
@adrien-berchet adrien-berchet deleted the region_grower branch September 6, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants