Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start an Elasticsearch container when running MainSuite #4794

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

imsdu
Copy link
Collaborator

@imsdu imsdu commented Mar 13, 2024

No description provided.

Copy link
Contributor

@olivergrabinski olivergrabinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove the 60s timeout in the MainSuite, no? (Just a note)

@@ -172,9 +172,6 @@ services:
- "127.0.0.1:4510-4559:4510-4559"
environment:
- DEBUG=${DEBUG:-0}
volumes:
- "${LOCALSTACK_VOLUME_DIR:-./volume}:/var/lib/localstack"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one responsible for the mayhem in our runners

@imsdu imsdu merged commit 5e27222 into BlueBrain:master Mar 13, 2024
3 of 4 checks passed
@imsdu imsdu deleted the remove-elasticsearch-dep-mainsuite branch March 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants