This repository was archived by the owner on Feb 26, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
Deprecate alternative ways of computing inter-spike-intervals [vcs: #minor] #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 66.22% 68.49% +2.27%
==========================================
Files 33 36 +3
Lines 6504 6446 -58
Branches 2279 2087 -192
==========================================
+ Hits 4307 4415 +108
- Misses 273 275 +2
+ Partials 1924 1756 -168 ☔ View full report in Codecov by Sentry. |
ilkilic
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! looks good to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Having 3 different implementations for computing the inter-spike-intervals (a commonly used feature) is causing lots of inconsistencies. This PR reduces those three to only a single implementation.
Changes
The users with python3.8 can still install it manually (the setup.py does not prevent it).
Checklist: