Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow for single basal #89

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Feat: Allow for single basal #89

merged 4 commits into from
Sep 28, 2023

Conversation

arnaudon
Copy link
Contributor

@arnaudon arnaudon commented Sep 28, 2023

Some cell types have a unique basal, hence we disable this check by setting a parameter to enforce at least 1, not 2.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #89 (9d04938) into main (5e8fe6a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          39       39           
  Lines        2191     2191           
  Branches      380      380           
=======================================
  Hits         2141     2141           
  Misses         30       30           
  Partials       20       20           
Flag Coverage Δ
pytest 97.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
neurots/extract_input/from_neurom.py 96.49% <100.00%> (ø)
neurots/extract_input/input_distributions.py 100.00% <ø> (ø)

Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just fix the coverage plz?

@arnaudon
Copy link
Contributor Author

LGTM, can you just fix the coverage plz?

done! (and improved the print message)

Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arnaudon arnaudon merged commit 37b773e into main Sep 28, 2023
9 checks passed
@arnaudon arnaudon deleted the single_basal branch September 28, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants