-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Allow for single basal #89
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 39 39
Lines 2191 2191
Branches 380 380
=======================================
Hits 2141 2141
Misses 30 30
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you just fix the coverage plz?
done! (and improved the print message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Some cell types have a unique basal, hence we disable this check by setting a parameter to enforce at least 1, not 2.