Fix tests/astrocyte/test_grower.py::test_grow__run test #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-berchet
force-pushed
the
fix_astrocyte_test
branch
2 times, most recently
from
408bb46
to
20b79ae
Compare
All numpy.cos and numpy.arccos values are rounded so that the returned values do not depend on which system libraries are used to compute them.
adrien-berchet
force-pushed
the
fix_astrocyte_test
branch
from
91ba491
to
4490980
Compare
adrien-berchet
commented
Feb 7, 2022
Comment on lines
+273
to
+274
| monkeypatch.setattr(np, "cos", _rounded_cos) | ||
| monkeypatch.setattr(np, "arccos", _rounded_arccos) |
There was a problem hiding this comment.
@eleftherioszisis After many tests I fixed this test by rounding all cos and arccos values. It seems to work (it works on both my local machine and BB5, which was not the case before that). Does it look good to you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.