-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3d trunk angles #49
3d trunk angles #49
Conversation
09832c3
to
c7b6b59
Compare
30e23cc
to
723e9cf
Compare
@lidakanari @adrien-berchet , I've clean up the main code, once we agree on it, I'll clean up the schema/tests so we can merge. I'm done with it for now. |
@lidakanari , I wait on your green light to start cleaning up test/schemas |
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 97.44% 97.56% +0.11%
==========================================
Files 38 39 +1
Lines 1954 2132 +178
Branches 288 324 +36
==========================================
+ Hits 1904 2080 +176
- Misses 34 35 +1
- Partials 16 17 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Co-authored-by: Adrien Berchet <adrien.berchet@gmail.com>
Finally! I can't spot what is not covered, maybe codecov needs some time to be up to date. |
ALL GREEEEN!!!!!! |
Yay 🥳 |
Co-authored-by: Adrien Berchet <adrien.berchet@epfl.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Finally double checking and all is good from my side to merge this one. @eleftherioszisis if you want to check for astrocytes please provide feedback for this, otherwise we are ok to merge this one. |
great thanks! I'll then make a minor release of neurots, so we can merge the dependencies |
No description provided.