Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diameter-synthesis by default #47

Merged
merged 7 commits into from
Jan 27, 2023
Merged

Use diameter-synthesis by default #47

merged 7 commits into from
Jan 27, 2023

Conversation

arnaudon
Copy link
Contributor

@arnaudon arnaudon commented Aug 30, 2022

  • Use diameter-synthesis latest algo as default instead of no diametrizer.
  • To use no_diametrizer, specify 'no_diameters' instead of 'default'.
  • We apply a post_growth operation of relabeling morphio section.id for easier use with external diametrizer, as any reloading to neurom for example will break the section.id mappings and will not allow one to easily change diamters of morphio object in place

@arnaudon arnaudon marked this pull request as ready for review August 31, 2022 09:44
@arnaudon arnaudon requested review from adrien-berchet and lidakanari and removed request for adrien-berchet August 31, 2022 09:46
@adrien-berchet adrien-berchet linked an issue Aug 31, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #47 (c966c74) into main (47fac7c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c966c74 differs from pull request most recent head 68989fa. Consider uploading reports for the commit 68989fa to get more accurate results

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   97.35%   97.36%   +0.01%     
==========================================
  Files          33       33              
  Lines        1892     1900       +8     
  Branches      280      281       +1     
==========================================
+ Hits         1842     1850       +8     
  Misses         34       34              
  Partials       16       16              
Flag Coverage Δ
pytest 97.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neurots/extract_input/input_distributions.py 100.00% <100.00%> (ø)
neurots/extract_input/input_parameters.py 97.43% <100.00%> (+0.06%) ⬆️
neurots/generate/grower.py 100.00% <100.00%> (ø)

neurots/generate/grower.py Show resolved Hide resolved
tests/test_neuron_functional.py Outdated Show resolved Hide resolved
@arnaudon
Copy link
Contributor Author

arnaudon commented Sep 5, 2022

@lidakanari ,are you good to merge that, so we can release and bump version, or shall we release before?

@arnaudon
Copy link
Contributor Author

arnaudon commented Nov 3, 2022

Shall we merge that?

@adrien-berchet
Copy link
Member

For me it looks good, I let @lidakanari approve.

@arnaudon arnaudon force-pushed the diameter_synthesis branch 2 times, most recently from 6525ad9 to c966c74 Compare January 27, 2023 09:42
@arnaudon arnaudon merged commit 57d28e3 into main Jan 27, 2023
@arnaudon arnaudon deleted the diameter_synthesis branch January 27, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make default diametrizer the new one
3 participants