-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use diameter-synthesis by default #47
Conversation
arnaudon
commented
Aug 30, 2022
•
edited
Loading
edited
- Use diameter-synthesis latest algo as default instead of no diametrizer.
- To use no_diametrizer, specify 'no_diameters' instead of 'default'.
- We apply a post_growth operation of relabeling morphio section.id for easier use with external diametrizer, as any reloading to neurom for example will break the section.id mappings and will not allow one to easily change diamters of morphio object in place
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 97.35% 97.36% +0.01%
==========================================
Files 33 33
Lines 1892 1900 +8
Branches 280 281 +1
==========================================
+ Hits 1842 1850 +8
Misses 34 34
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8e74495
to
87d7fff
Compare
@lidakanari ,are you good to merge that, so we can release and bump version, or shall we release before? |
92b9b3c
to
48e060b
Compare
Shall we merge that? |
For me it looks good, I let @lidakanari approve. |
6525ad9
to
c966c74
Compare
c966c74
to
68989fa
Compare