Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use commitlint to check PR titles #39

Merged
merged 2 commits into from
Jul 6, 2022
Merged

CI: Use commitlint to check PR titles #39

merged 2 commits into from
Jul 6, 2022

Conversation

adrien-berchet
Copy link
Member

@adrien-berchet adrien-berchet commented Jul 6, 2022

PR titles are used as commit titles in the main branch, so they have to be linted as other commit messages.

@adrien-berchet adrien-berchet changed the title CI: Use commitlint to check PR titles se commitlint to check PR titles Jul 6, 2022
@adrien-berchet adrien-berchet changed the title se commitlint to check PR titles CI: Use commitlint to check PR titles Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #39 (7ba732b) into main (0cb10e7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   97.20%   97.20%   -0.01%     
==========================================
  Files          34       34              
  Lines        1859     1858       -1     
  Branches      295      294       -1     
==========================================
- Hits         1807     1806       -1     
  Misses         35       35              
  Partials       17       17              
Flag Coverage Δ
pytest 97.20% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
neurots/extract_input/from_diameter.py 100.00% <ø> (ø)
neurots/generate/orientations.py 100.00% <100.00%> (ø)

@arnaudon arnaudon merged commit 0e70a3d into main Jul 6, 2022
@arnaudon arnaudon deleted the commitlint branch July 6, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants