Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #26

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Update pyproject.toml #26

merged 1 commit into from
Mar 7, 2022

Conversation

eleftherioszisis
Copy link
Contributor

@eleftherioszisis eleftherioszisis commented Mar 6, 2022

Add build-system entry as per https://setuptools.pypa.io/en/latest/build_meta.html

Reverted (See below for details):
Switch to preferred way to configure setuptools_scm

@eleftherioszisis
Copy link
Contributor Author

eleftherioszisis commented Mar 6, 2022

Unfortunately, I discovered that switching to the pyproject.toml configuration is not equivalent to using the setup.py as far as setuptools_scm is concerned.

setup.py commands do not install build dependencies from pyproject.toml, therefore if python setup.py --version is executed, it will silently return 0.0.0 with the pyproject.toml configuration unless the latest setuptools_scm[toml] and setuptools are already installed. Tox will also fail to get the version correctly for the same reason.

I will revert to the old way, as it is the most robust for the time being. Otherwise, we would need to add the dependencies in many places, such as in a setup.cfg and in tox.ini.

For more details, see:
pypa/setuptools-scm#386 (comment)

@adrien-berchet
Copy link
Member

Unfortunately, I discovered that switching to the pyproject.toml configuration is not equivalent to using the setup.py as far as setuptools_scm is concerned.

Ah 🤦

@eleftherioszisis eleftherioszisis merged commit 7aeb2b7 into main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants