Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Astrocyte grower infinite loop #104

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

jacquemi-bbp
Copy link
Contributor

@jacquemi-bbp jacquemi-bbp commented Apr 12, 2024

  • append a copy of point into the points list instead of a refence to the point.

Description

Fix 103

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the issue).
    • Please include tests that fail with the main branch and pass with the provided fix.
  • A new feature implementation or update an existing feature
    • Please include: Fixes: #<issue number> in the description if it solves an existing issue
      (which must include a complete example of the feature).
    • Please include tests that cover every lines of the new/updated feature.
    • Please update the documentation to describe the new/updated feature.

- append a copy of point into the points list instead of a refence to the point.
@jacquemi-bbp jacquemi-bbp changed the title Fix: Astrocyte grower infinite loop #103 Fixes: #<issue 103>: Astrocyte grower infinite loop Apr 12, 2024
@jacquemi-bbp jacquemi-bbp changed the title Fixes: #<issue 103>: Astrocyte grower infinite loop Fixes: #<103>: Astrocyte grower infinite loop Apr 12, 2024
@jacquemi-bbp jacquemi-bbp changed the title Fixes: #<103>: Astrocyte grower infinite loop Fixes: #103: Astrocyte grower infinite loop Apr 12, 2024
@jacquemi-bbp jacquemi-bbp changed the title Fixes: #103: Astrocyte grower infinite loop Fixes: #<103> Astrocyte grower infinite loop Apr 12, 2024
@jacquemi-bbp
Copy link
Contributor Author

How does the versioning of this package works ?
Do I need to change something for the versioning ?

@eleftherioszisis
Copy link
Contributor

How does the versioning of this package works ? Do I need to change something for the versioning ?

No, I don't think so. Versioning should be automatic when a new release is made.

@arnaudon
Copy link
Contributor

arnaudon commented Apr 12, 2024

write Fix: blabla in commit title, and remove #103, you can add this in description

@arnaudon
Copy link
Contributor

ah, this changes the algo a bit apparently, as a test break, I guess you can update the test, it should not be such a big deal, but @eleftherioszisis should know more

@eleftherioszisis
Copy link
Contributor

eleftherioszisis commented Apr 12, 2024

I guess you can update the test, it should not be such a big deal, but @eleftherioszisis should know more

It changes the tests, but it's indeed a bug, therefore it's ok to update them.

@jacquemi-bbp jacquemi-bbp changed the title Fixes: #<103> Astrocyte grower infinite loop Fixes: Astrocyte grower infinite loop Apr 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (d47bf8d) to head (fb82c3f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          39       39           
  Lines        2201     2201           
  Branches      383      383           
=======================================
  Hits         2154     2154           
  Misses         29       29           
  Partials       18       18           
Flag Coverage Δ
pytest 97.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
neurots/astrocyte/section.py 80.24% <100.00%> (ø)

@jacquemi-bbp jacquemi-bbp changed the title Fixes: Astrocyte grower infinite loop Fix: Astrocyte grower infinite loop Apr 15, 2024
@jacquemi-bbp
Copy link
Contributor Author

Is anything missing to merge the PR ?

@eleftherioszisis eleftherioszisis merged commit 4dc6db9 into BlueBrain:main Apr 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] The grow_to_target function used by AstrocyteGrower class has a an infinite loop
4 participants