-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Astrocyte grower infinite loop #104
Fix: Astrocyte grower infinite loop #104
Conversation
- append a copy of point into the points list instead of a refence to the point.
How does the versioning of this package works ? |
No, I don't think so. Versioning should be automatic when a new release is made. |
write |
ah, this changes the algo a bit apparently, as a test break, I guess you can update the test, it should not be such a big deal, but @eleftherioszisis should know more |
It changes the tests, but it's indeed a bug, therefore it's ok to update them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 39 39
Lines 2201 2201
Branches 383 383
=======================================
Hits 2154 2154
Misses 29 29
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Is anything missing to merge the PR ? |
Description
Fix 103
Checklist
This pull request is:
Fixes: #<issue number>
in the description if it solves an existing issue(which must include a complete example of the issue).
main
branch and pass with the provided fix.Fixes: #<issue number>
in the description if it solves an existing issue(which must include a complete example of the feature).