Move test code: strings and empty arrays. #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 94 96 +2
Lines 5998 5998
=======================================
Hits 5176 5176
Misses 822 822 ☔ View full report in Codecov by Sentry. |
matz-e
reviewed
May 13, 2024
doc/developer_guide.md
Outdated
| #### Selections | ||
| Anything selection related goes in `tests/unit/test_high_five_selection.cpp`. | ||
| Anything selection related goes in `tests/unit/test_string.cpp`. |
There was a problem hiding this comment.
Really? Seems more string related than anything! I think that maybe if the files are structured cleanly enough, we could generalize the documentation section to not have these fall out of sync.
matz-e
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.