Windows CI must be red when tests fail. #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
force-pushed
the
1uc/fix-windows-ci
branch
from
f251776
to
feadaed
Compare
|
This is failing intentionally. It demonstrates that now all groups of tests fail, as they should. We'll rebase just the CI fixes on top of the main branch, after review. |
alkino
approved these changes
Feb 21, 2024
The issue is that `bash -l {0}` seems to turn off the `set -e` behaviour
we see in the other pipelines. Simply asking for `bash`, leads to every
ctest invocation failing with an exit code (even tests that are know to
succeed).
Therefore, we put one test per stage of the pipeline, this ensures its
exit code is relevant for success/failure of the pipeline.
1uc
force-pushed
the
1uc/fix-windows-ci
branch
from
feadaed
to
c70bd58
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
=======================================
Coverage 85.45% 85.45%
=======================================
Files 92 92
Lines 5787 5787
=======================================
Hits 4945 4945
Misses 842 842 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counter example:
https://github.com/BlueBrain/HighFive/actions/runs/7976398553/job/21776889696?pr=947