Pass dimensions to 'serialize'. #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
force-pushed
the
1uc/serialize-with-dims
branch
from
4e43b51
to
28447c6
Compare
|
Since it changes the inspector, we should probably not merge this into |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #939 +/- ##
=======================================
Coverage 84.55% 84.55%
=======================================
Files 86 86
Lines 5220 5220
=======================================
Hits 4414 4414
Misses 806 806 ☔ View full report in Codecov by Sentry. |
1uc
force-pushed
the
1uc/serialize-with-dims
branch
from
2e39ee6
to
aaf8eb8
Compare
By passing the dimensions to `serialize` allows serializing nested
pointers. This was previously not possible because, we didn't know how
many elements the pointer pointed to.
The logic for obtaining the dimensions of the array is:
* When creating/opening the array the memspace is set to be the same
as the filespace.
* Performing a selection either leads to a simple (packed)
multi-dimensional memspace; or to a one-dimensional memspace.
Therefore, if we perform a write without selection, we know the
dimensions the input array must have. If we perform a selection we again
know the dimensions the input buffer needs to have.
1uc
force-pushed
the
1uc/serialize-with-dims
branch
from
aaf8eb8
to
c28af89
Compare
jorblancoa
approved these changes
Feb 16, 2024
matz-e
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing the dimensions to
serializeallows serializing nested pointers. This was previously not possible because, we didn't know how many elements the pointer pointed to.The logic for obtaining the dimensions of the array is:
When creating/opening the array the memspace is set to be the same as the filespace.
Performing a selection either leads to a simple (packed) multi-dimensional memspace; or to a one-dimensional memspace.
Therefore, if we perform a write without selection, we know the dimensions the input array must have. If we perform a selection we again know the dimensions the input buffer needs to have.