Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #include<boost/serialization/vector.hpp>. #903

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 19, 2023

The comments state the at some point boost serialization and boost numeric had an ordering requirement of certain headers.

It claimed:

// starting Boost 1.64, serialization header must come before ublas
#include <boost/serialization/vector.hpp>
#include <boost/numeric/ublas/matrix.hpp>

If this is still true then users must include the affected boost headers before including highfive/boost.hpp. However, we're no longer forcing the dependency onto all HighFive + Boost users.

The comments state the at some point boost serialization and
boost numeric had an ordering requirement of certain headers.

It claimed:

     // starting Boost 1.64, serialization header must come before ublas
     #include <boost/serialization/vector.hpp>
     #include <boost/numeric/ublas/matrix.hpp>

If this is still true then users must include the affected boost headers
before including `highfive/boost.hpp`. However, we're no longer forcing
the dependency onto all HighFive + Boost users.
@1uc 1uc added the v3 Anything that needs to be resolved before `v3`. label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ba4849) 86.13% compared to head (236f000) 85.96%.
Report is 1 commits behind head on master.

❗ Current head 236f000 differs from pull request most recent head 8d2b175. Consider uploading reports for the commit 8d2b175 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
- Coverage   86.13%   85.96%   -0.18%     
==========================================
  Files          90       89       -1     
  Lines        5858     5870      +12     
==========================================
  Hits         5046     5046              
- Misses        812      824      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review December 19, 2023 15:32
@alkino alkino merged commit c22ac21 into master Feb 8, 2024
34 checks passed
@alkino alkino deleted the 1uc/remove-boost-serialize branch February 8, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Anything that needs to be resolved before `v3`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants