Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap all used H5T functions. #883

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Wrap all used H5T functions. #883

merged 1 commit into from
Dec 4, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Dec 4, 2023

No description provided.

@1uc
Copy link
Collaborator Author

1uc commented Dec 4, 2023 •
edited
Loading

This splits out a reviewable chunk from #863.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (859d97b) 84.97% compared to head (559ad0d) 85.00%.

Files Patch % Lines
include/highfive/bits/h5t_wrapper.hpp 79.36% 13 Missing ⚠️
include/highfive/bits/h5_wrapper.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   84.97%   85.00%   +0.03%     
==========================================
  Files          72       73       +1     
  Lines        5118     5176      +58     
==========================================
+ Hits         4349     4400      +51     
- Misses        769      776       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review December 4, 2023 08:44
matz-e
matz-e approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@1uc 1uc merged commit 1b50bc1 into master Dec 4, 2023
36 checks passed
@1uc 1uc deleted the 1uc/h5t_wrapper branch December 4, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz-e matz-e matz-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1uc @matz-e