Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create_datatype<bool>(). #869

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fix create_datatype<bool>(). #869

merged 2 commits into from
Nov 27, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 27, 2023

Create the specialization from create_datatype<bool> and adds the tests to check that raw arrays of bool are bitwise compatible with the enum that's serialized.

Create the specialization from `create_datatype<bool>` and adds the
tests to check that raw arrays of bool are bitwise compatible with the
enum that's serialized.
@1uc 1uc force-pushed the 1uc/fix-create_datatype_bool branch from defe171 to 0a3dfa2 Compare November 27, 2023 08:34
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90f8fd6) 84.75% compared to head (a391f2b) 84.89%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #869      +/-   ##
==========================================
+ Coverage   84.75%   84.89%   +0.14%     
==========================================
  Files          70       70              
  Lines        5056     5090      +34     
==========================================
+ Hits         4285     4321      +36     
+ Misses        771      769       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review November 27, 2023 08:53
Copy link
Member

@alkino alkino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, I missed it when I added boolean

@1uc 1uc merged commit 9415a7c into master Nov 27, 2023
36 checks passed
@1uc 1uc deleted the 1uc/fix-create_datatype_bool branch November 27, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants