Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check error code of ?get_cset. #861

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Check error code of ?get_cset. #861

merged 1 commit into from
Nov 24, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 22, 2023

This will uncover the bug #856 and can be prevent from reoccurring by #858. It requires #860 and #856.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (90f8fd6) 84.75% compared to head (1dcbea6) 84.74%.

Files Patch % Lines
include/highfive/bits/H5ReadWrite_misc.hpp 80.00% 1 Missing ⚠️
include/highfive/bits/h5t_wrapper.hpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   84.75%   84.74%   -0.01%     
==========================================
  Files          70       70              
  Lines        5056     5061       +5     
==========================================
+ Hits         4285     4289       +4     
- Misses        771      772       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review November 22, 2023 10:05
@1uc 1uc merged commit acf0fea into master Nov 24, 2023
36 checks passed
@1uc 1uc deleted the 1uc/check-cset branch November 24, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants