Enshrine observable, but quirky behaviour. #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #855 +/- ##
==========================================
+ Coverage 84.72% 84.75% +0.03%
==========================================
Files 69 69
Lines 5042 5052 +10
==========================================
+ Hits 4272 4282 +10
Misses 770 770 ☔ View full report in Codecov by Sentry. |
This isn't desired behaviour. However, it's non-obvious and users might rely on it. Hence, it's being tested.
1uc
force-pushed
the
1uc/test-default-plist
branch
from
a9a70a2
to
bb3fc4b
Compare
matz-e
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't desired behaviour. However, it's non-obvious and users might rely on it. Hence, it's being tested.