Introduce '{Shallow,Deep}CopyBuffer'. #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the internal notion of buffers. We already need to copy non-contiguous data into a contiguous buffer. This commit simply makes this idea more explicit. The advantage is that each class can focus on its purpose and thereby simplify its code.
1uc
force-pushed
the
1uc/refactor-copy-buffers
branch
from
f21ca6a
to
3c62836
Compare
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
==========================================
+ Coverage 84.35% 84.65% +0.30%
==========================================
Files 68 68
Lines 4826 4797 -29
==========================================
- Hits 4071 4061 -10
+ Misses 755 736 -19
|
alkino
previously approved these changes
Jul 12, 2023
Co-authored-by: Nicolas Cornu <nicolas.cornu@epfl.ch>
alkino
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the internal notion of buffers. We already need to copy non-contiguous data into a contiguous buffer. This commit simply makes this idea more explicit.
The advantage is that each class can focus on its purpose and thereby simplify its code.