Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: Update Windows CI. #1034

Merged
merged 1 commit into from
Jul 26, 2024
Merged

backport: Update Windows CI. #1034

merged 1 commit into from
Jul 26, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jul 25, 2024

Since a recent update it seems that Windows 2022 now uses Visual Studio 2022 17.9 and doesn't include toolset v141 anymore.

@1uc 1uc changed the title Update Windows CI. (#1000) backport: Update Windows CI. (#1000) Jul 25, 2024
@1uc 1uc changed the title backport: Update Windows CI. (#1000) backport: Update Windows CI. Jul 25, 2024
@1uc
Copy link
Collaborator Author

1uc commented Jul 25, 2024

Backports: #1000

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (84d9ce8) to head (1018acc).

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.x    #1034   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          90       90           
  Lines        5858     5858           
=======================================
  Hits         5046     5046           
  Misses        812      812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review July 26, 2024 05:50
Since a recent update it seems that Windows 2022 now uses Visual Studio
2022 17.9 and doesn't include toolset v141 anymore.
@1uc 1uc force-pushed the 1uc/backport-update-windows-ci branch from f6ca4c2 to 1018acc Compare July 26, 2024 06:02
@1uc 1uc merged commit b71a6d4 into v2.x Jul 26, 2024
34 checks passed
@1uc 1uc deleted the 1uc/backport-update-windows-ci branch July 26, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants