Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor H5Easy to use core. #1016

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Refactor H5Easy to use core. #1016

merged 5 commits into from
Jun 21, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jun 10, 2024

Removes all custom implementations for serializing Eigen, XTensor, OpenCV, std::vector and uses HighFive core instead.

This allows us to remove most specialization, except the one for Eigen which serializes Matrix<double, 1, -1> as a one-dimensional array and reads it from one- or two-dimensional data.

@1uc
Copy link
Collaborator Author

1uc commented Jun 10, 2024

Note that it's current based on top of #1011.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.78%. Comparing base (cb77ede) to head (ca6cba3).

Files Patch % Lines
include/highfive/h5easy_bits/H5Easy_scalar.hpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
+ Coverage   86.72%   86.78%   +0.05%     
==========================================
  Files         102      101       -1     
  Lines        6043     5964      -79     
==========================================
- Hits         5241     5176      -65     
+ Misses        802      788      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review June 21, 2024 06:20
@pramodk pramodk requested a review from alkino June 21, 2024 06:37
@1uc 1uc merged commit 20fbd4c into master Jun 21, 2024
36 checks passed
@1uc 1uc deleted the 1uc/rework-easy branch June 21, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants