Make ~Object protected.
#1009
Merged
Make ~Object protected.
#1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since deleting HighFive objects through their common base class `Object` is not supported, we should make the dtor protected. See Core Guidelines C35, e.g. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-dtor-virtual
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1009 +/- ##
==========================================
- Coverage 86.82% 86.81% -0.01%
==========================================
Files 100 100
Lines 6080 6083 +3
==========================================
+ Hits 5279 5281 +2
- Misses 801 802 +1 ☔ View full report in Codecov by Sentry. |
matz-e
approved these changes
May 23, 2024
|
Closes #1008. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since deleting HighFive objects through their common base class
Objectis not supported, we should make the dtor protected.See Core Guidelines C35, e.g.
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-dtor-virtual