This repository was archived by the owner on Feb 26, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 100
replace_axon now allows the axon length and numbr of sections to be set #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienJaquier
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
It looks like your changes do pass our pycodestyle tests:
Could you fix that so that the tests pass, please? |
@AurelienJaquier Sure, pushed an update. |
Reverted part of the code, to retain default behaviour. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
+ Coverage 87.36% 87.38% +0.01%
==========================================
Files 50 50
Lines 4346 4351 +5
==========================================
+ Hits 3797 3802 +5
Misses 549 549 ☔ View full report in Codecov by Sentry. |
Thanks @Hjorthmedh for your contribution and your patience |
@AurelienJaquier Thank you! Have a great weekend! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our group members needs the ability to change the length of the axonal initial segment, and the number of sections in it. This pull request adds this ability by introducing
axon_stump_length
andaxon_stump_nsec
.