Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

fix exlude examples #467

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix exlude examples #467

merged 2 commits into from
Jun 19, 2024

Conversation

penguinpee
Copy link
Contributor

@penguinpee penguinpee commented Jul 20, 2023 •
edited
Loading

  • Fix exclusion of examples/

@penguinpee
Fix exclusion of examples/
ed2863f 
Otherwise examples will be installed as a top level module.
@penguinpee penguinpee force-pushed the fix_exlude_examples branch from 9953a91 to ed2863f Compare July 20, 2023 22:41
@penguinpee
Copy link
Contributor Author

See for more information the setuptools docs (the note and important boxes at the end of the linked section).

anilbey
anilbey approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anilbey
Copy link
Contributor

anilbey commented Jun 19, 2024

Thanks @penguinpee for finding out and fixing it.

I confirm with this change the examples are not added to the wheel. The .whl file is slightly smaller in size.

Before

216K ├── bluepyopt-1.14.12-py3-none-any.whl

After

208K ├── bluepyopt-1.14.12.1-py3-none-any.whl

@anilbey anilbey merged commit 4fcf47a into BlueBrain:master Jun 19, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anilbey anilbey anilbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@penguinpee @anilbey