Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PassParamsInNavigate): Passed params along with name while naviga… #35

Merged
merged 4 commits into from
Oct 18, 2019
Merged

fix(PassParamsInNavigate): Passed params along with name while naviga… #35

merged 4 commits into from
Oct 18, 2019

Conversation

aliwaqar981
Copy link
Contributor

Summary

Passed params alongside with name while navigating to other screen

Description

I have fixed bug which wasn't letting pass id during routing in native app.

Motivation and Context

This fix is required to make work place settings.

Types of changes

  • Bug Fix

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aliwaqar981
Copy link
Contributor Author

@artalat please merge

@artalat artalat changed the base branch from master to develop October 17, 2019 16:19
@artalat
Copy link
Contributor

artalat commented Oct 17, 2019

i have changed based to develop. you need to resolve conflicts

@aliwaqar981
Copy link
Contributor Author

@artalat please merge

@artalat artalat merged commit ef0bd97 into develop Oct 18, 2019
artalat pushed a commit that referenced this pull request Oct 18, 2019
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
f8377a9 
# [1.1.0](v1.0.0...v1.1.0) (2019-10-18)

### Bug Fixes

* **PassParamsInNavigate:** Passed params along with name in navigate fn ([#35](#35)) ([ef0bd97](ef0bd97)), closes [#15](#15) [#15](#15)

### Features

* Initial Release ([314810a](314810a))
@artalat
Copy link
Contributor

artalat commented Oct 18, 2019

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artalat artalat artalat approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliwaqar981 @artalat @adnan1naeem @semantic-release-bot