Battle engine revamp (turn sequence) and other misc stuff that is bothering me #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aeliko
added
bug
This was
linked to
issues
Oct 22, 2024
Open
Open
|
do you need anything from me to get this working? |
Not yet, just need a code review when I finish soon™️ |
BluRosie
reviewed
Jan 8, 2025
also fix the crash i was seeing, gBattleSystem wasn't initialized or something make no debug prints the default get rid of GET_HELD_ITEM_HOLD_EFFECT_ACCOUNTING_KLUTZ
BluRosie
force-pushed
the
battle-engine-revamp
branch
from
2cc925f to
ea3badb
Compare
blackisme1
reviewed
Jan 11, 2025
blackisme1
reviewed
Jan 11, 2025
|
per discord conversation... todo before merge:
|
BluRosie
force-pushed
the
battle-engine-revamp
branch
from
1518747 to
2612e65
Compare
add zstd to macos brew install list to fix BluRosie#368 clean up how to specify required directories in the makefile so that they are all created in one evocation
BluRosie
force-pushed
the
battle-engine-revamp
branch
2 times, most recently
from
5d42dd0 to
7b3d984
Compare
BluRosie
force-pushed
the
battle-engine-revamp
branch
from
7b3d984 to
291ef03
Compare
|
pursuit -> primal -> desolate land -> attacker message appears to work |
BluRosie
force-pushed
the
battle-engine-revamp
branch
from
1a8cc1a to
d61fb66
Compare
(no super effective/not very effective message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #313.
Remind me to either draw a diagram here or create a wiki page explaining what and why we need this.