PowerPC: Check for VSX and power8 arch for enabling altivec implementations #619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more checks of C macro for enabling the altivec implementations of shuffle and bitshuffle.
Indeed checking
__ALTIVEC__
is not enough (see #592 for details).I tested this as part of
hdf5plugin
(see silx-kit/hdf5plugin#307 (comment)).Checking only
__VSX__
was not enough since some features were added over time and I had issue compiling with-mcpu=power7
.Really not sure it is the best approach, but it looks to work for what I tested.
attn @barracuda156 @kif