Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CollectAllProperties flag and clean up reserved attributes #67

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix CollectAllProperties flag and clean up reserved attributes #67

merged 1 commit into from
Aug 16, 2023

Conversation

rvazarkar
Copy link
Contributor

Description

The CollectAllProperties flag was not working at all due to the call to IsTextUnicode pretty much always returning false

Motivation and Context

BloodHoundAD/SharpHound#56

How Has This Been Tested?

  • Tested locally in lab

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit 919c5fb into v3 Aug 16, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ddlees ddlees ddlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvazarkar @ddlees