- Add block sounds enum and remove default texture value under material instance #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanV2
requested changes
Jun 14, 2024
Comment on lines
+94
to
+192
| "enum": [ | ||
| "amethyst_block", | ||
| "amethyst_cluster", | ||
| "ancient_debris", | ||
| "anvil", | ||
| "azalea", | ||
| "azalea_leaves", | ||
| "bamboo", | ||
| "bamboo_sapling", | ||
| "bamboo_wood", | ||
| "bamboo_wood_hanging_sign", | ||
| "basalt", | ||
| "big_dripleaf", | ||
| "bone_block", | ||
| "calcite", | ||
| "candle", | ||
| "cave_vines", | ||
| "chain", | ||
| "cherry_leaves", | ||
| "cherry_wood", | ||
| "cherry_wood_hanging_sign", | ||
| "chiseled_bookshelf", | ||
| "cloth", | ||
| "comparator", | ||
| "copper", | ||
| "copper_bulb", | ||
| "copper_grate", | ||
| "coral", | ||
| "decorated_pot", | ||
| "deepslate", | ||
| "deepslate_bricks", | ||
| "dirt_with_roots", | ||
| "dripstone_block", | ||
| "frog_spawn", | ||
| "froglight", | ||
| "fungus", | ||
| "glass", | ||
| "grass", | ||
| "gravel", | ||
| "hanging_roots", | ||
| "hanging_sign", | ||
| "heavy_core", | ||
| "honey_block", | ||
| "itemframe", | ||
| "ladder", | ||
| "lantern", | ||
| "large_amethyst_bud", | ||
| "lever", | ||
| "lodestone", | ||
| "mangrove_roots", | ||
| "medium_amethyst_bud", | ||
| "metal", | ||
| "moss_block", | ||
| "moss_carpet", | ||
| "mud", | ||
| "mud_bricks", | ||
| "muddy_mangrove_roots", | ||
| "nether_brick", | ||
| "nether_gold_ore", | ||
| "nether_sprouts", | ||
| "nether_wart", | ||
| "nether_wood", | ||
| "nether_wood_hanging_sign", | ||
| "netherite", | ||
| "netherrack", | ||
| "nylium", | ||
| "packed_mud", | ||
| "pink_petals", | ||
| "pointed_dripstone", | ||
| "polished_tuff", | ||
| "powder_snow", | ||
| "roots", | ||
| "sand", | ||
| "scaffolding", | ||
| "sculk", | ||
| "sculk_catalyst", | ||
| "sculk_sensor", | ||
| "sculk_shrieker", | ||
| "sculk_vein", | ||
| "shroomlight", | ||
| "slime", | ||
| "small_amethyst_bud", | ||
| "snow", | ||
| "soul_sand", | ||
| "soul_soil", | ||
| "spore_blossom", | ||
| "stem", | ||
| "stone", | ||
| "suspicious_gravel", | ||
| "suspicious_sand", | ||
| "sweet_berry_bush", | ||
| "trial_spawner", | ||
| "tuff", | ||
| "tuff_bricks", | ||
| "vault", | ||
| "vines", | ||
| "web", | ||
| "wood" | ||
| ] |
There was a problem hiding this comment.
Sorry cant have this as an enum as its able to have custom enums, this should be done through the json path completion in the vscode extension
There was a problem hiding this comment.
You can only use the vanilla block values and these are it. Are you saying you can use custom ones?
There was a problem hiding this comment.
I'm pretty sure you can't
There was a problem hiding this comment.
It's limited to vanilla sounds unfortunately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.