Update blocks and items to newest format #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add glint
- Remove on_use_on
- Remove use_duration
DaanV2
requested changes
Feb 10, 2024
There was a problem hiding this comment.
Good job! really added onto it all.
Got one small nitpick and another is that there needs to be a couple of extra updates.
in:
- source/behavior/blocks/format/minecraft.block.json
This json has a list of all the components, currently the removed components are still mentioned and the new ones need to be added. - source/behavior/items/format/minecraft.item.json
Same as blocks
But all in all good job 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.