Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run consume logic in a separate thread #982

Merged
merged 21 commits into from
Jan 20, 2023
Merged

Run consume logic in a separate thread #982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
00e1511
librdkafka 1.9.0
GaryWilber Jun 16, 2022
e11ea06
revert new line removal
GaryWilber Jun 17, 2022
c5bb0dc
update version in readme
GaryWilber Jun 17, 2022
52eaef7
librdkafka 1.9.1
GaryWilber Jul 12, 2022
4a9856e
update windows-install script to copy new libcurl dll
GaryWilber Jul 28, 2022
383360e
v1.9.2
GaryWilber Aug 2, 2022
102578b
update readme links to 1.9.2
GaryWilber Aug 15, 2022
a9099d4
separate thread for consume loop
GaryWilber Sep 20, 2022
a1b4505
change where consume_async is opened / closed
GaryWilber Sep 21, 2022
6fc412d
reuse existing classes
GaryWilber Sep 22, 2022
3e5732d
remove whitespace change
GaryWilber Sep 22, 2022
fcd0e10
update error
GaryWilber Sep 22, 2022
74cf215
rename variable for clarify
GaryWilber Sep 22, 2022
690607c
add semver dependency for update-version.js
GaryWilber Sep 30, 2022
a47aa80
test dependencies
GaryWilber Sep 30, 2022
e7ec97c
test
GaryWilber Sep 30, 2022
c8027f4
move semver back to dev deps
GaryWilber Sep 30, 2022
305e71b
Merge branch 'master' into user/garywilb/threaded_consume_2
GaryWilber Oct 17, 2022
49daafb
cleanup
GaryWilber Oct 17, 2022
7ee9a25
remove semver
GaryWilber Oct 31, 2022
e7dc75d
update shrinkwrap
GaryWilber Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/kafka-consumer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ KafkaConsumer.prototype.unsubscribe = function() {
* is fetched.
*/
KafkaConsumer.prototype.consume = function(number, cb) {
var timeoutMs = this._consumeTimeout || DEFAULT_CONSUME_TIME_OUT;
var timeoutMs = this._consumeTimeout !== undefined ? this._consumeTimeout : DEFAULT_CONSUME_TIME_OUT;
var self = this;

if ((number && typeof number === 'number') || (number && cb)) {
Expand Down
Loading