Support transactions #903
Merged
Support transactions #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replication factor of transaction related options should be reduced to 1 so that we can test with a single broker.
returned by Rdkafka to the JS code.
Also don't allow single offset
Timeout added on producing messages.
Some transaction end to end tests were failing for two reasons. * A delayed message from prevoius test was being read and braking up the logic of the test. Fixed by using a separate topic. * One more message was being produced than expected. Fixed.
Closed
|
I pushed the code for async version. We now need to make proper e2e tests. |
thynson
reviewed
Aug 7, 2021
thynson
reviewed
Aug 7, 2021
thynson
reviewed
Aug 7, 2021
|
I tried this feature locally, except TypeError caused by adding async support, all the other parts are good to me so far. |
|
The only missing thing is updated docs, but this can be done in a separate PR or commit. Thank you @YordanPavlov, and everyone who participated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pull request to expose the transactions support of LibrdKafka.
This PR is a copy of the PR:
#881
some commits were cleaned by interactive rebase.