-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read the download url of librdkafka from Windows environment variable #816
Read the download url of librdkafka from Windows environment variable #816
Conversation
LGTM. |
@iradul Consider this pull request? |
There is this |
I read the code of binding.gyp, the |
I have renamed |
Let's call this variable |
…L in windows-install.py
done |
Expecting this merge can be published to npm. We can not bear the network in China now. |
@yunnysunny I just released the new version |
In Windows ,the download of the library of librdkafka may be so slowly, especially when you are in China. It may cost a long time to download it. Sometime I have to wait for several hours.
So I add an feature of reading the download url from environment variable.