Export event types for use with abstract Client class #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without exported event types, they must be duplicated in dependant code to correctly use the abstract
Client
class, which is needed when either a Producer or Consumer client could be the value of a class field. If no events are supplied to theClient
class, then subscribing to event listeners doesn't work. When these types are duplicated in the dependant code and passed like_client?: Client<KafkaProducerEvents | KafkaConsumerEvents>
, the event listener typings work correctly.Exporting these types is the least effort to enable this usecase, otherwise requiring larger changes to how the abstract class is typed. One cannot say
_client?: KafkaConsumer | Producer
because then the event listener functions have conflicting types and cannot be used at all.